Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Wifi instability when light is on, due to sleep=0 (#6961, #6608) #6980

Merged
merged 2 commits into from
Nov 21, 2019
Merged

Fix Wifi instability when light is on, due to sleep=0 (#6961, #6608) #6980

merged 2 commits into from
Nov 21, 2019

Conversation

s-hadinger
Copy link
Collaborator

Description:

sleep = 0 is currently force when light is on, which creates some wifi instability. This PR forces a minimum value sleep = 50 when lights are on to ensure smooth animations and keep wifi stability.

Related issue (if applicable): fixes #6961 #6608

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on core 2.6
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

@s-hadinger
Copy link
Collaborator Author

@arendst I changed to sleep = 10 which looks to be a good compromise: wifi is still stable, animation won't be broken, and flickering won't be visible (100 Hz is too fast for the human eye).

@arendst arendst merged commit 6706c89 into arendst:development Nov 21, 2019
@s-hadinger s-hadinger mentioned this pull request Nov 24, 2019
Merged
6 tasks
@s-hadinger s-hadinger deleted the fix_sleep_light branch November 26, 2019 09:35
@s-hadinger s-hadinger mentioned this pull request Dec 3, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Losing device after upgrade from 7.0.0.3 to 7.0.0.5
2 participants
@s-hadinger @arendst